Messages in this thread | | | Subject | Re: [PATCH v12 04/18] kunit: test: add assertion printing library | From | Stephen Boyd <> | Date | Mon, 12 Aug 2019 21:57:46 -0700 |
| |
Quoting Brendan Higgins (2019-08-12 21:27:05) > On Mon, Aug 12, 2019 at 4:56 PM Brendan Higgins > <brendanhiggins@google.com> wrote: > > > > On Mon, Aug 12, 2019 at 4:46 PM Stephen Boyd <sboyd@kernel.org> wrote: > > > > > > Quoting Brendan Higgins (2019-08-12 11:24:07) > > > > +#define KUNIT_INIT_FAIL_ASSERT_STRUCT(test, type) { \ > > > > + .assert = KUNIT_INIT_ASSERT_STRUCT(test, \ > > > > + type, \ > > > > + kunit_fail_assert_format) \ > > > > > > This one got indented one too many times? > > > > Not unless I have been using the wrong formatting for multiline > > macros. You can see this commit applied here: > > https://kunit.googlesource.com/linux/+/870964da2990920030990dd1ffb647ef408e52df/include/kunit/assert.h#59 > > > > I have test, type, and kunit_fail_assert_format all column aligned (it > > just doesn't render nicely in the patch format). > > Disregard that last comment. I just looked at the line immediately > above your comment and thought it looked correct. Sorry about that > (you were pointing out that the .assert line looked wrong, correct?).
Yes. .assert is double tabbed?
| |