[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH net-next v2 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores
++ Jakub

From: David Miller <>
Date: Aug/12/2019, 22:06:18 (UTC+00:00)

> From: Jose Abreu <>
> Date: Mon, 12 Aug 2019 11:44:03 +0200
> > - Add performance info (David)
> Ummm...
> Whilst cpu utilization is interesting, I might be mainly interested in
> how this effects "networking" performance. I find it very surprising
> that it isn't obvious that this is what I wanted.
> Do you not do performance testing on the networking level when you
> make fundamental changes to how packets are processed by the
> hardware/driver?

I do.

In my HW this feature does not impact performance neither improves it as
I'm already on max of theoretical bandwidth.

I do expect it to reduce CPU usage and memory footprint because we no
longer have to memcpy the entire buffer to SKB and instead we just copy
the header and then append payload as page which is passed directly to
net layer.

This feature is already used in some drivers and is part of GRO
offloading I think.

Jakub, as David is off can you please comment on how can we proceed with
this series ? I can add more information in commit log for this patch

Jose Miguel Abreu

 \ /
  Last update: 2019-08-13 10:31    [W:0.040 / U:5.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site