Messages in this thread | | | From | Xiaowei Bao <> | Subject | RE: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver. | Date | Tue, 13 Aug 2019 07:39:48 +0000 |
| |
> -----Original Message----- > From: Kishon Vijay Abraham I <kishon@ti.com> > Sent: 2019年8月13日 15:30 > To: Xiaowei Bao <xiaowei.bao@nxp.com>; lorenzo.pieralisi@arm.com; > bhelgaas@google.com; M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu > <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>; > l.stach@pengutronix.de; tpiepho@impinj.com; Leonard Crestez > <leonard.crestez@nxp.com>; andrew.smirnov@gmail.com; > yue.wang@amlogic.com; hayashi.kunihiko@socionext.com; > dwmw@amazon.co.uk; jonnyc@amazon.com; linux-pci@vger.kernel.org; > linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > linux-arm-kernel@lists.infradead.org > Subject: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit > property in EP driver. > > Caution: EXT Email > > On 13/08/19 11:58 AM, Xiaowei Bao wrote: > > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is > > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set > > the bar_fixed_64bit with 0x14. > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > > Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > > --- > > v2: > > - Replace value 0x14 with a macro. > > v3: > > - No change. > > v4: > > - send the patch again with '--to'. > > v5: > > - fix the commit message. > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index be61d96..ca9aa45 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -44,6 +44,7 @@ static const struct pci_epc_features > ls_pcie_epc_features = { > > .linkup_notifier = false, > > .msi_capable = true, > > .msix_capable = false, > > + .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > > }; > > > > static const struct pci_epc_features* I check other platforms, it is 'static const struct pci_epc_features', I can get the correct Value use this define way in pci-epf-test.c file. > >
| |