lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 16/33] net: usb: pegasus: fix improper read if get_registers() fail
    Date
    From: Denis Kirjanov <kda@linux-powerpc.org>

    [ Upstream commit 224c04973db1125fcebefffd86115f99f50f8277 ]

    get_registers() may fail with -ENOMEM and in this
    case we can read a garbage from the status variable tmp.

    Reported-by: syzbot+3499a83b2d062ae409d4@syzkaller.appspotmail.com
    Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/usb/pegasus.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
    index ee40ac23507a0..5fe9f1273fe20 100644
    --- a/drivers/net/usb/pegasus.c
    +++ b/drivers/net/usb/pegasus.c
    @@ -285,7 +285,7 @@ static void mdio_write(struct net_device *dev, int phy_id, int loc, int val)
    static int read_eprom_word(pegasus_t *pegasus, __u8 index, __u16 *retdata)
    {
    int i;
    - __u8 tmp;
    + __u8 tmp = 0;
    __le16 retdatai;
    int ret;

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-08-14 04:56    [W:4.277 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site