Messages in this thread | | | Date | Tue, 13 Aug 2019 08:20:18 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v5 03/10] rtc: mt6397: move some common definitions into rtc.h |
| |
On Mon, 12 Aug 2019, Alexandre Belloni wrote:
> On 12/08/2019 16:11:29+0100, Lee Jones wrote: > > On Mon, 12 Aug 2019, Frank Wunderlich wrote: > > > > > From: Josef Friedl <josef.friedl@speed.at> > > > > > > move code to separate header-file to reuse definitions later > > > in poweroff-driver (drivers/power/reset/mt6323-poweroff.c) > > > > > > Suggested-by: Frank Wunderlich <frank-w@public-files.de> > > > Signed-off-by: Josef Friedl <josef.friedl@speed.at> > > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > > --- > > > changes since v4: none > > > changes since v3: none > > > changes since v2: add missing commit-message > > > --- > > > drivers/rtc/rtc-mt6397.c | 55 +------------------------- > > > include/linux/mfd/mt6397/rtc.h | 71 ++++++++++++++++++++++++++++++++++ > > > > include/linux/rtc/mt6397.h? > > > > It's just a bunch of registers and bit definitions so it may as well > stay close to include/linux/mfd/mt6397/registers.h
Sure. It was a weak preference.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |