lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ahci: Remove the exporting of ahci_em_messages
From
Date
Hi Jens,

On 11.07.2019 04:03, Liu, Chuansheng wrote:
>> -----Original Message-----
>> From: Denis Efremov [mailto:efremov@linux.com]
>> Sent: Wednesday, July 10, 2019 11:29 PM
>> To: Liu, Chuansheng <chuansheng.liu@intel.com>
>> Cc: Denis Efremov <efremov@linux.com>; Jens Axboe <axboe@kernel.dk>;
>> linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
>>
>> The variable ahci_em_messages is declared static and marked
>> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
>> variable is not used outside of the drivers/ata/libahci.c file it is
>> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
>
> Sounds good to me, thanks.
> Reviewed-by: Chuansheng Liu <chuansheng.liu@linux.intel.com>
>

Could you please look at this patch once again and accept it if it's ok?
static ahci_em_messages will trigger a warning after this check
will be in tree https://lkml.org/lkml/2019/7/14/118

Thanks,
Denis

\
 
 \ /
  Last update: 2019-08-13 23:45    [W:0.042 / U:24.704 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site