Messages in this thread Patch in this message | | | From | Leo Li <> | Subject | RE: [PATCH] dmaengine: fsldma: Mark expected switch fall-through | Date | Mon, 12 Aug 2019 19:40:58 +0000 |
| |
> -----Original Message----- > From: Gustavo A. R. Silva <gustavo@embeddedor.com> > Sent: Sunday, August 11, 2019 7:22 PM > To: Leo Li <leoyang.li@nxp.com>; Zhang Wei <zw@zh-kernel.org>; Vinod > Koul <vkoul@kernel.org>; Dan Williams <dan.j.williams@intel.com> > Cc: linuxppc-dev@lists.ozlabs.org; dmaengine@vger.kernel.org; linux- > kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com> > Subject: [PATCH] dmaengine: fsldma: Mark expected switch fall-through > > Mark switch cases where we are expecting to fall through. > > Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc): > > drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’: > drivers/dma/fsldma.c:1165:26: warning: this statement may fall through [- > Wimplicit-fallthrough=] > chan->toggle_ext_pause = fsl_chan_toggle_ext_pause; > ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/dma/fsldma.c:1166:2: note: here > case FSL_DMA_IP_83XX: > ^~~~ > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> --- > drivers/dma/fsldma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index > 23e0a356f167..ad72b3f42ffa 100644 > --- a/drivers/dma/fsldma.c > +++ b/drivers/dma/fsldma.c > @@ -1163,6 +1163,7 @@ static int fsl_dma_chan_probe(struct > fsldma_device *fdev, > switch (chan->feature & FSL_DMA_IP_MASK) { > case FSL_DMA_IP_85XX: > chan->toggle_ext_pause = fsl_chan_toggle_ext_pause; > + /* Fall through */ > case FSL_DMA_IP_83XX: > chan->toggle_ext_start = fsl_chan_toggle_ext_start; > chan->set_src_loop_size = fsl_chan_set_src_loop_size; > -- > 2.22.0
| |