Messages in this thread Patch in this message | | | Date | Mon, 12 Aug 2019 11:40:04 -0700 | From | tip-bot for Borislav Petkov <> | Subject | [tip:x86/urgent] x86/apic/32: Fix yet another implicit fallthrough warning |
| |
Commit-ID: 5785675dfef4f9edcee66edef7b3af21618d2707 Gitweb: https://git.kernel.org/tip/5785675dfef4f9edcee66edef7b3af21618d2707 Author: Borislav Petkov <bp@suse.de> AuthorDate: Sun, 11 Aug 2019 17:40:36 +0200 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Mon, 12 Aug 2019 20:35:04 +0200
x86/apic/32: Fix yet another implicit fallthrough warning
Fix
arch/x86/kernel/apic/probe_32.c: In function ‘default_setup_apic_routing’: arch/x86/kernel/apic/probe_32.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (!APIC_XAPIC(version)) { ^ arch/x86/kernel/apic/probe_32.c:151:3: note: here case X86_VENDOR_HYGON: ^~~~
for 32-bit builds.
Signed-off-by: Borislav Petkov <bp@suse.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lkml.kernel.org/r/20190811154036.29805-1-bp@alien8.de
--- arch/x86/kernel/apic/probe_32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/probe_32.c b/arch/x86/kernel/apic/probe_32.c index 1492799b8f43..ee2d91e382f1 100644 --- a/arch/x86/kernel/apic/probe_32.c +++ b/arch/x86/kernel/apic/probe_32.c @@ -184,7 +184,8 @@ void __init default_setup_apic_routing(void) def_to_bigsmp = 0; break; } - /* If P4 and above fall through */ + /* P4 and above */ + /* fall through */ case X86_VENDOR_HYGON: case X86_VENDOR_AMD: def_to_bigsmp = 1;
| |