lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [EXT] Re: i2c: imx: support slave mode for imx I2C driver
    Date
    > Subject: Re: [EXT] Re: i2c: imx: support slave mode for imx I2C driver
    >
    > Caution: EXT Email
    >
    > On Fri, Aug 09, 2019 at 04:04:45AM +0000, Biwen Li wrote:
    > > >
    > > > Hi,
    > > >
    > > > On Thu, Aug 08, 2019 at 11:53:43AM +0800, Biwen Li wrote:
    > > > > The patch supports slave mode for imx I2C driver
    > > > >
    > > > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
    > > > > ---
    > > > > drivers/i2c/busses/i2c-imx.c | 199
    > > > > ++++++++++++++++++++++++++++++++---
    > > > > 1 file changed, 185 insertions(+), 14 deletions(-)
    > > > >
    > > > > diff --git a/drivers/i2c/busses/i2c-imx.c
    > > > > b/drivers/i2c/busses/i2c-imx.c index b1b8b938d7f4..f7583a9fa56f
    > > > > 100644
    > > > > --- a/drivers/i2c/busses/i2c-imx.c
    > > > > +++ b/drivers/i2c/busses/i2c-imx.c
    > > > > @@ -202,6 +202,9 @@ struct imx_i2c_struct {
    > > > > struct pinctrl_state *pinctrl_pins_gpio;
    > > > >
    > > > > struct imx_i2c_dma *dma;
    > > > > +#if IS_ENABLED(CONFIG_I2C_SLAVE)
    > > > > + struct i2c_client *slave;
    > > > > +#endif /* CONFIG_I2C_SLAVE */
    > > >
    > > > Other drivers just do a "select I2C_SLAVE" in Kconfig to get rid of
    > > > these #ifs. We should do the same.
    > > Hi sascha, I don't know your meaning, could you let it clearer?
    >
    > Other drivers have "select I2C_SLAVE" in Kconfig, so they do not need any #ifdef
    > CONFIG_I2C_SLAVE as this is always true.
    Okay, sascha, got it, I will remove the option in v2, thanks.
    >
    > Sascha
    >
    > --
    > Pengutronix e.K. |
    > |
    > Industrial Linux Solutions |
    > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
    > ngutronix.de%2F&amp;data=02%7C01%7Cbiwen.li%40nxp.com%7C2ad7a8ef
    > 04c84f224a9808d71eefaf43%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
    > %7C0%7C637011887098895560&amp;sdata=Dde7Hi6eMWcg7SM8T63eBtgY
    > XsQPu3HFJaZMt6z8Vck%3D&amp;reserved=0 |
    > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
    > |
    > Amtsgericht Hildesheim, HRA 2686 | Fax:
    > +49-5121-206917-5555 |

    \
     
     \ /
      Last update: 2019-08-12 09:12    [W:3.947 / U:1.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site