lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/3] mm: kmemleak: Use a memory pool for kmemleak object allocations
On Mon, 12 Aug 2019 17:06:39 +0100 Catalin Marinas <catalin.marinas@arm.com> wrote:

> Following the discussions on v2 of this patch(set) [1], this series
> takes slightly different approach:
>
> - it implements its own simple memory pool that does not rely on the
> slab allocator
>
> - drops the early log buffer logic entirely since it can now allocate
> metadata from the memory pool directly before kmemleak is fully
> initialised
>
> - CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE option is renamed to
> CONFIG_DEBUG_KMEMLEAK_MEM_POOL_SIZE
>
> - moves the kmemleak_init() call earlier (mm_init())
>
> - to avoid a separate memory pool for struct scan_area, it makes the
> tool robust when such allocations fail as scan areas are rather an
> optimisation
>
> [1] http://lkml.kernel.org/r/20190727132334.9184-1-catalin.marinas@arm.com

Using the term "memory pool" is a little unfortunate, but better than
using "mempool"!

The changelog doesn't answer the very first question: why not use
mempools. Please send along a paragraph which explains this decision.

\
 
 \ /
  Last update: 2019-08-12 23:08    [W:0.134 / U:2.652 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site