Messages in this thread | | | Date | Sun, 11 Aug 2019 21:22:22 -0700 (PDT) | Subject | Re: [PATCH][net-next] rxrpc: fix uninitialized return value in variable err | From | David Miller <> |
| |
From: Colin King <colin.king@canonical.com> Date: Fri, 9 Aug 2019 18:02:59 +0100
> From: Colin Ian King <colin.king@canonical.com> > > An earlier commit removed the setting of err to -ENOMEM so currently > the skb_shinfo(skb)->nr_frags > 16 check returns with an uninitialized > bogus return code. Fix this by setting err to -ENOMEM to restore > the original behaviour. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: b214b2d8f277 ("rxrpc: Don't use skb_cow_data() in rxkad") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
David, I assume you will pick this up.
| |