lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 1/4] arm64: dts: ls1088a: Fix incorrect I2C clock divider
    Date


    > -----Original Message-----
    > From: Shawn Guo <shawnguo@kernel.org>
    > Sent: Monday, August 12, 2019 9:17 AM
    > To: Chuanhua Han <chuanhua.han@nxp.com>
    > Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org;
    > mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
    > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
    > Subject: Re: [PATCH 1/4] arm64: dts: ls1088a: Fix incorrect I2C clock divider
    >
    > On Tue, Aug 06, 2019 at 04:42:20PM +0800, Chuanhua Han wrote:
    > > Ls1088a platform, the i2c input clock is actually platform pll CLK / 8
    > > (this is the hardware connection), other clock divider can not get the
    > > correct i2c clock, resulting in the output of SCL pin clock is not
    > > accurate.
    > >
    > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
    >
    > @Leo, looks good?

    Yes.

    Acked-by: Li Yang <leoyang.li@nxp.com>

    >
    > Shawn
    >
    > > ---
    > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 8 ++++----
    > > 1 file changed, 4 insertions(+), 4 deletions(-)
    > >
    > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
    > > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
    > > index 20f5ebd..30b760e 100644
    > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
    > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
    > > @@ -324,7 +324,7 @@
    > > #size-cells = <0>;
    > > reg = <0x0 0x2000000 0x0 0x10000>;
    > > interrupts = <0 34 IRQ_TYPE_LEVEL_HIGH>;
    > > - clocks = <&clockgen 4 3>;
    > > + clocks = <&clockgen 4 7>;
    > > status = "disabled";
    > > };
    > >
    > > @@ -334,7 +334,7 @@
    > > #size-cells = <0>;
    > > reg = <0x0 0x2010000 0x0 0x10000>;
    > > interrupts = <0 34 IRQ_TYPE_LEVEL_HIGH>;
    > > - clocks = <&clockgen 4 3>;
    > > + clocks = <&clockgen 4 7>;
    > > status = "disabled";
    > > };
    > >
    > > @@ -344,7 +344,7 @@
    > > #size-cells = <0>;
    > > reg = <0x0 0x2020000 0x0 0x10000>;
    > > interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>;
    > > - clocks = <&clockgen 4 3>;
    > > + clocks = <&clockgen 4 7>;
    > > status = "disabled";
    > > };
    > >
    > > @@ -354,7 +354,7 @@
    > > #size-cells = <0>;
    > > reg = <0x0 0x2030000 0x0 0x10000>;
    > > interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>;
    > > - clocks = <&clockgen 4 3>;
    > > + clocks = <&clockgen 4 7>;
    > > status = "disabled";
    > > };
    > >
    > > --
    > > 2.9.5
    > >

    \
     
     \ /
      Last update: 2019-08-12 23:01    [W:3.185 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site