lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] checkpatch: Prefer __section over __attribute__((section(...)))
On Mon, Aug 12, 2019 at 1:07 PM Joe Perches <joe@perches.com> wrote:
>
> Add another test for __attribute__((section("foo"))) uses
> that should be __section(foo)
>
> Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Joe Perches <joe@perches.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com> # post PEBKAC <smile>

lol please don't commit that (PEBKAC)

> ---
> scripts/checkpatch.pl | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 1cdacb4fd207..d4153b81b1eb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5901,6 +5901,18 @@ sub process {
> "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
> }
>
> +# Check for __attribute__ section, prefer __section
> + if ($realfile !~ m@\binclude/uapi/@ &&
> + $line =~ /\b__attribute__\s*\(\s*\(.*_*section_*\s*\(\s*("[^"]*")/) {
> + my $old = substr($rawline, $-[1], $+[1] - $-[1]);
> + my $new = substr($old, 1, -1);
> + if (WARN("PREFER_SECTION",
> + "__section($new) is preferred over __attribute__((section($old)))\n" . $herecurr) &&
> + $fix) {
> + $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*_*section_*\s*\(\s*\Q$old\E\s*\)\s*\)/__section($new)/;
> + }
> + }
> +
> # Check for __attribute__ format(printf, prefer __printf
> if ($realfile !~ m@\binclude/uapi/@ &&
> $line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
>
>


--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2019-08-12 22:32    [W:0.036 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site