lkml.org 
[lkml]   [2019]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v10 08/15] memory: tegra20-emc: wait_for_completion_timeout() doesn't return error
    Date
    The "interruptible" variant may error out, the "uninterruptible" not.

    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    ---
    drivers/memory/tegra/tegra20-emc.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
    index da75efc632c7..1b23b1c34476 100644
    --- a/drivers/memory/tegra/tegra20-emc.c
    +++ b/drivers/memory/tegra/tegra20-emc.c
    @@ -224,7 +224,7 @@ static int emc_prepare_timing_change(struct tegra_emc *emc, unsigned long rate)

    static int emc_complete_timing_change(struct tegra_emc *emc, bool flush)
    {
    - long timeout;
    + unsigned long timeout;

    dev_dbg(emc->dev, "%s: flush %d\n", __func__, flush);

    @@ -240,10 +240,6 @@ static int emc_complete_timing_change(struct tegra_emc *emc, bool flush)
    if (timeout == 0) {
    dev_err(emc->dev, "EMC-CAR handshake failed\n");
    return -EIO;
    - } else if (timeout < 0) {
    - dev_err(emc->dev, "failed to wait for EMC-CAR handshake: %ld\n",
    - timeout);
    - return timeout;
    }

    return 0;
    --
    2.22.0
    \
     
     \ /
      Last update: 2019-08-11 23:03    [W:2.077 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site