lkml.org 
[lkml]   [2019]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dpaa2-ethsw: move the DPAA2 Ethernet Switch driver out of staging
Hi Ioana

> >> + struct ethsw_port_priv *port_priv = netdev_priv(netdev);
> >> + struct ethsw_core *ethsw = port_priv->ethsw_data;
> >> + int i, err;
> >> +
> >> + for (i = 0; i < ethsw->sw_attr.num_ifs; i++)
> >> + if (ethsw->ports[i]->bridge_dev &&
> >> + (ethsw->ports[i]->bridge_dev != upper_dev)) {
> >> + netdev_err(netdev,
> >> + "Another switch port is connected to %s\n",
> >> + ethsw->ports[i]->bridge_dev->name);
> >> + return -EINVAL;
> >> + }
> >
> > Am i reading this correct? You only support a single bridge? The
> > error message is not very informative. Also, i think you should be
> > returning EOPNOTSUPP, indicating the offload is not possible. Linux
> > will then do it in software. If it could actually receive/transmit the
> > frames....
> >
>
> Yes, we only support a single bridge.

That is a pretty severe restriction for a device of this class. Some
of the very simple switches DSA support have a similar restriction,
but in general, most do support multiple bridges.

Are there any plans to fix this?

Thanks
Andrew

\
 
 \ /
  Last update: 2019-08-11 05:23    [W:0.072 / U:52.300 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site