lkml.org 
[lkml]   [2019]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 148/157] ipv6: Fix fragment id assignment on LE arches.
    3.16.72-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vlad Yasevich <vyasevich@gmail.com>

    commit 51f30770e50eb787200f30a79105e2615b379334 upstream.

    Recent commit:
    0508c07f5e0c94f38afd5434e8b2a55b84553077
    Author: Vlad Yasevich <vyasevich@gmail.com>
    Date: Tue Feb 3 16:36:15 2015 -0500

    ipv6: Select fragment id during UFO segmentation if not set.

    Introduced a bug on LE in how ipv6 fragment id is assigned.
    This was cought by nightly sparce check:

    Resolve the following sparce error:
    net/ipv6/output_core.c:57:38: sparse: incorrect type in assignment
    (different base types)
    net/ipv6/output_core.c:57:38: expected restricted __be32
    [usertype] ip6_frag_id
    net/ipv6/output_core.c:57:38: got unsigned int [unsigned]
    [assigned] [usertype] id

    Fixes: 0508c07f5e0c9 (ipv6: Select fragment id during UFO segmentation if not set.)
    Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/ipv6/output_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv6/output_core.c
    +++ b/net/ipv6/output_core.c
    @@ -54,7 +54,7 @@ void ipv6_proxy_select_ident(struct sk_b

    id = __ipv6_select_ident(ip6_proxy_idents_hashrnd,
    &addrs[1], &addrs[0]);
    - skb_shinfo(skb)->ip6_frag_id = id;
    + skb_shinfo(skb)->ip6_frag_id = htonl(id);
    }
    EXPORT_SYMBOL_GPL(ipv6_proxy_select_ident);

    \
     
     \ /
      Last update: 2019-08-10 22:50    [W:4.134 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site