[lkml]   [2019]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 3.16 091/157] cifs: fix handle leak in smb2_query_symlink()
3.16.72-rc1 review patch.  If anyone has any objections, please let me know.


From: Ronnie Sahlberg <>

commit e6d0fb7b34f264f72c33053558a360a6a734905e upstream.

If we enter smb2_query_symlink() for something that is not a symlink
and where the SMB2_open() would succeed we would never end up
closing this handle and would thus leak a handle on the server.

Fix this by immediately calling SMB2_close() on successfull open.

Signed-off-by: Ronnie Sahlberg <>
Signed-off-by: Steve French <>
Reviewed-by: Pavel Shilovsky <>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <>
fs/cifs/smb2ops.c | 2 ++
1 file changed, 2 insertions(+)

--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -906,6 +906,8 @@ smb2_query_symlink(const unsigned int xi

rc = SMB2_open(xid, &oparms, utf16_path, &oplock, NULL, &err_buf);

+ if (!rc)
+ SMB2_close(xid, tcon, fid.persistent_fid, fid.volatile_fid);
if (!rc || !err_buf) {
return -ENOENT;
 \ /
  Last update: 2019-08-10 22:48    [W:0.382 / U:33.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site