lkml.org 
[lkml]   [2019]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] habanalabs: print to kernel log when reset is finished
On Sat, Aug 10, 2019 at 3:53 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Aug 10, 2019 at 03:38:08PM +0300, Oded Gabbay wrote:
> > Now that we don't print the queue testing messages, we need to print when
> > the reset is finished so whoever looks at the kernel log will know the
> > reset process was finished successfully and the driver is not stuck.
> >
> > Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
> > ---
> > drivers/misc/habanalabs/device.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/misc/habanalabs/device.c b/drivers/misc/habanalabs/device.c
> > index 9a5926888b99..1fac808c2546 100644
> > --- a/drivers/misc/habanalabs/device.c
> > +++ b/drivers/misc/habanalabs/device.c
> > @@ -907,6 +907,8 @@ int hl_device_reset(struct hl_device *hdev, bool hard_reset,
> > else
> > hdev->soft_reset_cnt++;
> >
> > + dev_info(hdev->dev, "Successfully finished resetting the device\n");
>
> Really? For doing things "properly" there is no need to spam the kernel
> log. Only spit stuff out if an error happens.
>
> thanks,
>
> greg k-h

I beg to differ for two reasons:
1. Reset happens very rarely, if at all. So this message (that get
printed after reset is done) will definitely not spam the kernel log.
2. When a reset starts we print an appropriate error message. I think
it is expected by the user that we will also print if and when the
reset has finished successfully. I really believe that lack of this
printing might be deceiving for users.

Thanks,
Oded

\
 
 \ /
  Last update: 2019-08-10 17:30    [W:0.039 / U:1.424 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site