lkml.org 
[lkml]   [2019]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement
On Fri, Aug 09, 2019 at 11:59:44PM -0500, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>
> If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.
>
> arch/sh/kernel/hw_breakpoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
> index 3bd010b4c55f..f10d64311127 100644
> --- a/arch/sh/kernel/hw_breakpoint.c
> +++ b/arch/sh/kernel/hw_breakpoint.c
> @@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
> switch (sh_type) {
> case SH_BREAKPOINT_READ:
> *gen_type = HW_BREAKPOINT_R;
> + break;
> case SH_BREAKPOINT_WRITE:
> *gen_type = HW_BREAKPOINT_W;
> break;
> --
> 2.22.0
>

\
 
 \ /
  Last update: 2019-08-10 14:54    [W:0.064 / U:32.016 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site