lkml.org 
[lkml]   [2019]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next v2 2/9] net: macsec: move some definitions in a dedicated header
Date

Hi Antoine,

Overall good looking patchset, great!

> +/**
> + * struct macsec_tx_sa - transmit secure association
> + * @active:
> + * @next_pn: packet number to use for the next packet
> + * @lock: protects next_pn manipulations
> + * @key: key structure
> + * @stats: per-SA stats
> + */
> +struct macsec_tx_sa {
> + struct macsec_key key;
> + spinlock_t lock;
> + u32 next_pn;
> + refcount_t refcnt;
> + bool active;
> + bool offloaded;

I don't see this `offloaded` field being used anywhere. Is this needed?

Regards,
Igor
\
 
 \ /
  Last update: 2019-08-10 14:20    [W:0.084 / U:1.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site