Messages in this thread Patch in this message | | | Subject | Re: [PATCH] sh: kernel: disassemble: Mark expected switch fall-throughs | From | Joe Perches <> | Date | Fri, 09 Aug 2019 22:08:45 -0700 |
| |
On Sat, 2019-08-10 at 00:01 -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > Fix the following warnings (Building: defconfig sh): [] > diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c [] > @@ -477,6 +477,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) > case FD_REG_N: > if (0) > goto d_reg_n;
Might as well remove this if (0) goto, remove the added comment
> + /* else, fall through */ > case F_REG_N: > printk("fr%d", rn); > break; > @@ -488,6 +489,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) > printk("xd%d", rn & ~1); > break; > } > + /* else, fall through */ > d_reg_n:
and remove this only use of d_reg_n
> case D_REG_N: > printk("dr%d", rn); > @@ -497,6 +499,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) > printk("xd%d", rm & ~1); > break; > } > + /* else, fall through */ > case D_REG_M: > printk("dr%d", rm); > break;
| |