lkml.org 
[lkml]   [2019]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RFC memory-model 05/31] tools/memory-model: Make judgelitmus.sh detect hard deadlocks
    Date
    If a litmus test specifies "Result: Never" and if it contains an
    unconditional ("hard") deadlock, then running checklitmus.sh on it will
    not flag any errors, despite the fact that there are no executions.
    This commit therefore updates judgelitmus.sh to complain about tests
    with no executions that are marked, but not as "Result: DEADLOCK".

    Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
    ---
    tools/memory-model/scripts/judgelitmus.sh | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/tools/memory-model/scripts/judgelitmus.sh b/tools/memory-model/scripts/judgelitmus.sh
    index d40439c7b71e..84c62eee321b 100755
    --- a/tools/memory-model/scripts/judgelitmus.sh
    +++ b/tools/memory-model/scripts/judgelitmus.sh
    @@ -83,6 +83,14 @@ then
    fi
    ret=1
    fi
    +elif grep '^Observation' $LKMM_DESTDIR/$litmus.out | grep -q 'Never 0 0$'
    +then
    + echo " !!! Unexpected non-$outcome deadlock" $litmus
    + if ! grep -q '!!!' $LKMM_DESTDIR/$litmus.out
    + then
    + echo " !!! Unexpected non-$outcome deadlock" $litmus >> $LKMM_DESTDIR/$litmus.out 2>&1
    + fi
    + ret=1
    elif grep '^Observation' $LKMM_DESTDIR/$litmus.out | grep -q $outcome || test "$outcome" = Maybe
    then
    ret=0
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-08-02 00:22    [W:2.888 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site