lkml.org 
[lkml]   [2019]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drivers/amba: add reset control to primecell probe
Date
From: Dinh Nguyen <dinh.nguyen@intel.com>

The primecell controller on some SoCs, i.e. SoCFPGA, is held in reset by
default. Until recently, the DMA controller was brought out of reset by the
bootloader(i.e. U-Boot). But a recent change in U-Boot, the peripherals that
are not used are held in reset and are left to Linux to bring them out of
reset.

Add a mechanism for getting the reset property and de-assert the primecell
module from reset if found. This is a not a hard fail if the reset property
is not present in the device tree node, so the driver will continue to probe.

Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
drivers/of/platform.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 7801e25e6895..d8945705313d 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -21,6 +21,7 @@
#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
+#include <linux/reset.h>

const struct of_device_id of_default_bus_match_table[] = {
{ .compatible = "simple-bus", },
@@ -229,6 +230,7 @@ static struct amba_device *of_amba_device_create(struct device_node *node,
struct amba_device *dev;
const void *prop;
int i, ret;
+ struct reset_control *rstc;

pr_debug("Creating amba device %pOF\n", node);

@@ -270,6 +272,18 @@ static struct amba_device *of_amba_device_create(struct device_node *node,
goto err_free;
}

+ /*
+ * reset control of the primecell block is optional
+ * and will not fail if the reset property is not found.
+ */
+ rstc = of_reset_control_get_exclusive(node, "dma");
+ if (!IS_ERR(rstc)) {
+ reset_control_deassert(rstc);
+ reset_control_put(rstc);
+ } else {
+ pr_debug("amba: reset control not found\n");
+ }
+
ret = amba_device_add(dev, &iomem_resource);
if (ret) {
pr_err("amba_device_add() failed (%d) for %pOF\n",
--
2.20.0
\
 
 \ /
  Last update: 2019-08-01 20:45    [W:0.070 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site