Messages in this thread | | | Subject | Re: [PATCH v9 10/21] mm: Add generic p?d_leaf() macros | From | Anshuman Khandual <> | Date | Thu, 1 Aug 2019 11:43:38 +0530 |
| |
On 07/29/2019 06:20 PM, Mark Rutland wrote: > On Sun, Jul 28, 2019 at 05:14:31PM +0530, Anshuman Khandual wrote: >> On 07/23/2019 03:11 PM, Mark Rutland wrote: >>> It might also be worth pointing out the reasons for this naming, e.g. >>> p?d_large() aren't currently generic, and this name minimizes potential >>> confusion between p?d_{large,huge}(). >> >> Agreed. But these fallback also need to first check non-availability of large >> pages. > > We're deliberately not making the p?d_large() helpers generic, so this > shouldn't fall back on those.
I meant non-availability of large page support in the MMU HW not just the presence of p?d_large() helpers.
| |