Messages in this thread | | | Subject | Re: [PATCH v2] HID: input: fix a4tech horizontal wheel custom usage | From | Nicolas Saenz Julienne <> | Date | Thu, 01 Aug 2019 12:56:51 +0200 |
| |
On Tue, 2019-06-11 at 14:13 +0200, Nicolas Saenz Julienne wrote: > Some a4tech mice use the 'GenericDesktop.00b8' usage to inform whether > the previous wheel report was horizontal or vertical. Before > c01908a14bf73 ("HID: input: add mapping for "Toggle Display" key") this > usage was being mapped to 'Relative.Misc'. After the patch it's simply > ignored (usage->type == 0 & usage->code == 0). Which ultimately makes > hid-a4tech ignore the WHEEL/HWHEEL selection event, as it has no > usage->type. > > We shouldn't rely on a mapping for that usage as it's nonstandard and > doesn't really map to an input event. So we bypass the mapping and make > sure the custom event handling properly handles both reports. > > Fixes: c01908a14bf73 ("HID: input: add mapping for "Toggle Display" key") > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > ---
It would be nice for this patch not to get lost. It fixes issues both repoted on opensuse and fedora.
I can resubmit it if needed.
Regards, Nicolas
[unhandled content-type:application/pgp-signature] | |