Messages in this thread | | | Subject | Re: [PATCH 2/2] pinctrl: qcom: Add SC7180 pinctrl driver | From | Rajendra Nayak <> | Date | Fri, 2 Aug 2019 08:00:31 +0530 |
| |
On 8/1/2019 8:06 PM, Bjorn Andersson wrote: > On Thu 01 Aug 03:07 PDT 2019, Rajendra Nayak wrote: > > [..] >> +static const struct msm_pingroup sc7180_groups[] = { >> + [0] = PINGROUP(0, SOUTH, qup01, cri_trng, _, phase_flag, _, _, _, _, _), >> + [1] = PINGROUP(1, SOUTH, qup01, cri_trng, _, phase_flag, _, _, _, _, _), >> + [2] = PINGROUP(2, SOUTH, qup01, cri_trng, _, phase_flag, _, _, _, _, _), >> + [3] = PINGROUP(3, SOUTH, qup01, sp_cmu, dbg_out, qdss_cti, _, _, _, _, _), >> + [4] = PINGROUP(4, NORTH, sdc1_tb, _, qdss_cti, _, _, _, _, _, _), [5] = PINGROUP(5, NORTH, sdc2_tb, _, _, _, _, _, _, _, _), >> + [6] = PINGROUP(6, NORTH, qup11, qup11, _, _, _, _, _, _, _), [7] = PINGROUP(7, NORTH, qup11, qup11, ddr_bist, _, _, _, _, _, _), > > 5 and 7 deserve to be on their own line :)
Oops, looks like some formatting mess, I'll fix and resend.
> > Apart from that: > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
thanks for the review.
> > Regards, > Bjorn >
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |