lkml.org 
[lkml]   [2019]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v7 03/14] nvmet: add return value to nvmet_add_async_event()
    From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

    Change the return value for nvmet_add_async_event().

    This change is needed for the target passthru code to generate async
    events.

    Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
    [logang@deltatee.com: fixed up commit message that was no
    longer accurate]
    Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
    ---
    drivers/nvme/target/core.c | 5 +++--
    drivers/nvme/target/nvmet.h | 2 +-
    2 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
    index 3a67e244e568..f7f25bdc4763 100644
    --- a/drivers/nvme/target/core.c
    +++ b/drivers/nvme/target/core.c
    @@ -173,14 +173,14 @@ static void nvmet_async_event_work(struct work_struct *work)
    }
    }

    -void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type,
    +bool nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type,
    u8 event_info, u8 log_page)
    {
    struct nvmet_async_event *aen;

    aen = kmalloc(sizeof(*aen), GFP_KERNEL);
    if (!aen)
    - return;
    + return false;

    aen->event_type = event_type;
    aen->event_info = event_info;
    @@ -191,6 +191,7 @@ void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type,
    mutex_unlock(&ctrl->lock);

    schedule_work(&ctrl->async_event_work);
    + return true;
    }

    static void nvmet_add_to_changed_ns_log(struct nvmet_ctrl *ctrl, __le32 nsid)
    diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
    index c51f8dd01dc4..217a787952e8 100644
    --- a/drivers/nvme/target/nvmet.h
    +++ b/drivers/nvme/target/nvmet.h
    @@ -441,7 +441,7 @@ void nvmet_port_disc_changed(struct nvmet_port *port,
    struct nvmet_subsys *subsys);
    void nvmet_subsys_disc_changed(struct nvmet_subsys *subsys,
    struct nvmet_host *host);
    -void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type,
    +bool nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type,
    u8 event_info, u8 log_page);

    #define NVMET_QUEUE_SIZE 1024
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-08-02 01:47    [W:4.067 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site