lkml.org 
[lkml]   [2019]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] sound: soc: bcm: cygnus-pcm: Unneeded variable: "ret".
    This patch fixes below issues reported by coccicheck

    sound/soc/bcm/cygnus-pcm.c:642:5-8: Unneeded variable: "ret". Return "0"
    on line 650
    sound/soc/bcm/cygnus-pcm.c:671:5-8: Unneeded variable: "ret". Return "0"
    on line 696

    We cannot change return type of these functions as they are callback
    functions of snd_pcm_ops

    Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
    ---
    sound/soc/bcm/cygnus-pcm.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/sound/soc/bcm/cygnus-pcm.c b/sound/soc/bcm/cygnus-pcm.c
    index 123ecf5..8966b02 100644
    --- a/sound/soc/bcm/cygnus-pcm.c
    +++ b/sound/soc/bcm/cygnus-pcm.c
    @@ -639,7 +639,6 @@ static int cygnus_pcm_hw_params(struct snd_pcm_substream *substream,
    struct snd_soc_pcm_runtime *rtd = substream->private_data;
    struct snd_pcm_runtime *runtime = substream->runtime;
    struct cygnus_aio_port *aio;
    - int ret = 0;

    aio = cygnus_dai_get_dma_data(substream);
    dev_dbg(rtd->cpu_dai->dev, "%s port %d\n", __func__, aio->portnum);
    @@ -647,7 +646,7 @@ static int cygnus_pcm_hw_params(struct snd_pcm_substream *substream,
    snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer);
    runtime->dma_bytes = params_buffer_bytes(params);

    - return ret;
    + return 0;
    }

    static int cygnus_pcm_hw_free(struct snd_pcm_substream *substream)
    @@ -668,7 +667,6 @@ static int cygnus_pcm_prepare(struct snd_pcm_substream *substream)
    struct snd_pcm_runtime *runtime = substream->runtime;
    struct cygnus_aio_port *aio;
    unsigned long bufsize, periodsize;
    - int ret = 0;
    bool is_play;
    u32 start;
    struct ringbuf_regs *p_rbuf = NULL;
    @@ -693,7 +691,7 @@ static int cygnus_pcm_prepare(struct snd_pcm_substream *substream)
    ringbuf_set_initial(aio->cygaud->audio, p_rbuf, is_play, start,
    periodsize, bufsize);

    - return ret;
    + return 0;
    }

    static snd_pcm_uframes_t cygnus_pcm_pointer(struct snd_pcm_substream *substream)
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-07-09 20:43    [W:5.008 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site