lkml.org 
[lkml]   [2019]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: memory leaks from xfs_rw_bdev()
From
Date
On Mon, 2019-07-08 at 23:35 +0200, Christoph Hellwig wrote:
> We actually have a discussion on that in another thread, but if you
> can easily reproduce the issue, can you test the patch below?
>
> diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c
> index 757c1d9293eb..e2148f2d5d6b 100644
> --- a/fs/xfs/xfs_bio_io.c
> +++ b/fs/xfs/xfs_bio_io.c
> @@ -43,7 +43,7 @@ xfs_rw_bdev(
>   bio_copy_dev(bio, prev);
>   bio->bi_iter.bi_sector = bio_end_sector(prev);
>   bio->bi_opf = prev->bi_opf;
> - bio_chain(bio, prev);
> + bio_chain(prev, bio);
>  
>   submit_bio(prev);
>   }

Yes, it works fine.

\
 
 \ /
  Last update: 2019-07-09 20:34    [W:0.061 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site