lkml.org 
[lkml]   [2019]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 08/90] ASoC : cs4265 : readable register too low
    Date
    [ Upstream commit f3df05c805983427319eddc2411a2105ee1757cf ]

    The cs4265_readable_register function stopped short of the maximum
    register.

    An example bug is taken from :
    https://github.com/Audio-Injector/Ultra/issues/25

    Where alsactl store fails with :
    Cannot read control '2,0,0,C Data Buffer,0': Input/output error

    This patch fixes the bug by setting the cs4265 to have readable
    registers up to the maximum hardware register CS4265_MAX_REGISTER.

    Signed-off-by: Matt Flax <flatmax@flatmax.org>
    Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/cs4265.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
    index 407554175282..68d18aca397d 100644
    --- a/sound/soc/codecs/cs4265.c
    +++ b/sound/soc/codecs/cs4265.c
    @@ -60,7 +60,7 @@ static const struct reg_default cs4265_reg_defaults[] = {
    static bool cs4265_readable_register(struct device *dev, unsigned int reg)
    {
    switch (reg) {
    - case CS4265_CHIP_ID ... CS4265_SPDIF_CTL2:
    + case CS4265_CHIP_ID ... CS4265_MAX_REGISTER:
    return true;
    default:
    return false;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-08 17:41    [W:5.250 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site