lkml.org 
[lkml]   [2019]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 27/73] cfg80211: fix memory leak of wiphy device name
    Date
    From: Eric Biggers <ebiggers@google.com>

    commit 4f488fbca2a86cc7714a128952eead92cac279ab upstream.

    In wiphy_new_nm(), if an error occurs after dev_set_name() and
    device_initialize() have already been called, it's necessary to call
    put_device() (via wiphy_free()) to avoid a memory leak.

    Reported-by: syzbot+7fddca22578bc67c3fe4@syzkaller.appspotmail.com
    Fixes: 1f87f7d3a3b4 ("cfg80211: add rfkill support")
    Cc: stable@vger.kernel.org
    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/wireless/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/wireless/core.c
    +++ b/net/wireless/core.c
    @@ -447,7 +447,7 @@ use_default_name:
    &rdev->rfkill_ops, rdev);

    if (!rdev->rfkill) {
    - kfree(rdev);
    + wiphy_free(&rdev->wiphy);
    return NULL;
    }


    \
     
     \ /
      Last update: 2019-07-08 17:16    [W:4.131 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site