Messages in this thread | | | From | Chris Packham <> | Subject | Re: [PATCH] tipc: ensure skb->lock is initialised | Date | Mon, 8 Jul 2019 20:43:47 +0000 |
| |
On 8/07/19 8:18 PM, Eric Dumazet wrote: > > > On 7/8/19 12:53 AM, Chris Packham wrote: >> tipc_named_node_up() creates a skb list. It passes the list to >> tipc_node_xmit() which has some code paths that can call >> skb_queue_purge() which relies on the list->lock being initialised. >> Ensure tipc_named_node_up() uses skb_queue_head_init() so that the lock >> is explicitly initialised. >> >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > > I would rather change the faulty skb_queue_purge() to __skb_queue_purge() >
Makes sense. I'll look at that for v2.
| |