Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 8 Jul 2019 22:39:48 +0200 | Subject | Re: [PATCH] m68k: don't select ARCH_HAS_DMA_PREP_COHERENT for nommu or coldfire |
| |
Hi Christoph,
On Mon, Jul 8, 2019 at 7:51 PM Christoph Hellwig <hch@lst.de> wrote: > > m68k only provides the dma_prep_coherent symbol when an mmu is enabled
arch_dma_prep_coherent
> and not on the coldfire platform. Fix the Kconfig symbol selection > up to match this. > > Fixes: 69878ef47562 ("m68k: Implement arch_dma_prep_coherent()")
Do you know the SHA1 for the other commit, that causes the issue when combined with the above?
> Reported-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> --- a/arch/m68k/Kconfig > +++ b/arch/m68k/Kconfig > @@ -5,7 +5,7 @@ config M68K > select ARCH_32BIT_OFF_T > select ARCH_HAS_BINFMT_FLAT > select ARCH_HAS_DMA_MMAP_PGPROT if MMU && !COLDFIRE > - select ARCH_HAS_DMA_PREP_COHERENT > + select ARCH_HAS_DMA_PREP_COHERENT if HAS_DMA && MMU && !COLDFIRE > select ARCH_HAS_SYNC_DMA_FOR_DEVICE if HAS_DMA > select ARCH_MIGHT_HAVE_PC_PARPORT if ISA > select ARCH_NO_COHERENT_DMA_MMAP if !MMU
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |