Messages in this thread | | | Subject | Re: [PATCH] tracing: make exported ftrace_set_clr_event non-static | From | Joe Jin <> | Date | Sun, 7 Jul 2019 08:46:12 -0700 |
| |
Patch looks good to me.
Reviewed-by: Joe Jin <joe.jin@oracle.com>
Thanks, Joe On 7/4/19 10:21 AM, Denis Efremov wrote: > The function ftrace_set_clr_event is declared static and marked > EXPORT_SYMBOL_GPL(), which is at best an odd combination. Because the > function was decided to be a part of API, this commit removes the static > attribute and adds the declaration to the header. > > Fixes: f45d1225adb04 ("tracing: Kernel access to Ftrace instances") > Signed-off-by: Denis Efremov <efremov@linux.com> > --- > include/linux/trace_events.h | 1 + > kernel/trace/trace_events.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h > index 8a62731673f7..84bc84f00e8f 100644 > --- a/include/linux/trace_events.h > +++ b/include/linux/trace_events.h > @@ -539,6 +539,7 @@ extern int trace_event_get_offsets(struct trace_event_call *call); > > #define is_signed_type(type) (((type)(-1)) < (type)1) > > +int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set); > int trace_set_clr_event(const char *system, const char *event, int set); > > /* > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 0ce3db67f556..b6b46184f6bf 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -795,7 +795,7 @@ static int __ftrace_set_clr_event(struct trace_array *tr, const char *match, > return ret; > } > > -static int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set) > +int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set) > { > char *event = NULL, *sub = NULL, *match; > int ret; >
| |