lkml.org 
[lkml]   [2019]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 107/129] cpufreq: pxa2xx: remove incorrect __init annotation
    3.16.70-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    commit 9505b98ccddc454008ca7efff90044e3e857c827 upstream.

    pxa_cpufreq_init_voltages() is marked __init but usually inlined into
    the non-__init pxa_cpufreq_init() function. When building with clang,
    it can stay as a standalone function in a discarded section, and produce
    this warning:

    WARNING: vmlinux.o(.text+0x616a00): Section mismatch in reference from the function pxa_cpufreq_init() to the function .init.text:pxa_cpufreq_init_voltages()
    The function pxa_cpufreq_init() references
    the function __init pxa_cpufreq_init_voltages().
    This is often because pxa_cpufreq_init lacks a __init
    annotation or the annotation of pxa_cpufreq_init_voltages is wrong.

    Fixes: 50e77fcd790e ("ARM: pxa: remove __init from cpufreq_driver->init()")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
    Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/cpufreq/pxa2xx-cpufreq.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/cpufreq/pxa2xx-cpufreq.c
    +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
    @@ -191,7 +191,7 @@ static int pxa_cpufreq_change_voltage(px
    return ret;
    }

    -static void __init pxa_cpufreq_init_voltages(void)
    +static void pxa_cpufreq_init_voltages(void)
    {
    vcc_core = regulator_get(NULL, "vcc_core");
    if (IS_ERR(vcc_core)) {
    @@ -207,7 +207,7 @@ static int pxa_cpufreq_change_voltage(px
    return 0;
    }

    -static void __init pxa_cpufreq_init_voltages(void) { }
    +static void pxa_cpufreq_init_voltages(void) { }
    #endif

    static void find_freq_tables(struct cpufreq_frequency_table **freq_table,
    \
     
     \ /
      Last update: 2019-07-07 21:41    [W:4.498 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site