lkml.org 
[lkml]   [2019]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: ipc/sem: Three function calls less in do_semtimedop()
From
Date
>> +		list_add_tail(&queue.list,
>> + alter
>> + ? (sma->complex_count
>> + ? &sma->pending_alter
>> + : &curr->pending_alter)
>> + : &curr->pending_const);
>
> Just no. This is making the code harder to comprehend

This can be according to your current view.


> with no advantage.

I propose to take additional aspects into account for the interpretation
of such source code.
The shown design direction can provide benefits which might get
a lower value for the software development attention so far.


>> + list_add_tail(&queue.list,
>> + alter ? &sma->pending_alter : &sma->pending_const);

Can this code variant look more succinct?

Regards,
Markus

\
 
 \ /
  Last update: 2019-07-07 09:11    [W:0.115 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site