Messages in this thread | | | Subject | Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver | From | Jarkko Sakkinen <> | Date | Fri, 05 Jul 2019 14:02:06 +0300 |
| |
On Fri, 2019-07-05 at 13:42 +0300, Jarkko Sakkinen wrote: > On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote: > > The nr_allocated_banks and allocated banks are initialized as part of > > tpm_chip_register. Currently, this is done as part of auto startup > > function. However, some drivers, like the ibm vtpm driver, do not run > > auto startup during initialization. This results in uninitialized memory > > issue and causes a kernel panic during boot. > > > > This patch moves the pcr allocation outside the auto startup function > > into tpm_chip_register. This ensures that allocated banks are initialized > > in any case. > > > > Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with > > PCR read") > > Signed-off-by: Nayna Jain <nayna@linux.ibm.com> > > Please add > > Reported-by: Michal Suchanek <msuchanek@suse.de> > > It is missing. Michal is there a chance you could try this out once > Nayna send a new version?
Hey, I saw Michal's tested-by. I can do that minor reorg cosmetic bits myeslf and add Micha's tag.
Some issue with the network but I'll push a commit soonish.
/Jarkko
| |