lkml.org 
[lkml]   [2019]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] thunderbolt: Move NVM upgrade support flag to struct icm
On Fri, Jul 05, 2019 at 01:52:49PM +0300, Yehezkel Bernat wrote:
> > @@ -2054,6 +2059,7 @@ struct tb *icm_probe(struct tb_nhi *nhi)
> > case PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_NHI:
> > case PCI_DEVICE_ID_INTEL_TITAN_RIDGE_4C_NHI:
> > icm->max_boot_acl = ICM_AR_PREBOOT_ACL_ENTRIES;
> > + icm->can_upgrade_nvm = true;
>
> Shouldn't this be also !x86_apple_machine just like AR?
> (For FR, we don't use ICM on Apple machines, as much as I remember, so it's fine
> to enable it there unconditionally for ICM code path.)

Yes, good point. I'll fix it up.

\
 
 \ /
  Last update: 2019-07-05 12:59    [W:0.117 / U:6.852 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site