lkml.org 
[lkml]   [2019]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [v1] gpu: ipu-v3: allow to build with ARCH_LAYERSCAPE
From
Date
Hi Wen,

On Wed, 2019-05-08 at 10:56 +0000, Wen He wrote:
> The new LS1028A DP driver code causes a link failure when DRM_IMX built-in,
> but platform is ARCH_LAYERSCAPE:
>
> drivers/gpu/drm/imx/ipuv3-crtc.c:51: undefined reference to `ipu_prg_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.c:52: undefined reference to `ipu_dc_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.c:53: undefined reference to `ipu_dc_enable_channel'
> drivers/gpu/drm/imx/ipuv3-crtc.c:54: undefined reference to `ipu_di_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.o: In function `ipu_crtc_mode_set_nofb
>
> Adding a Kconfig dependency allow to build if ARCH_LAYERSCAPE is enable.
>
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
> drivers/gpu/ipu-v3/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/ipu-v3/Kconfig b/drivers/gpu/ipu-v3/Kconfig
> index fe6f8c5b4445..51ea88c440df 100644
> --- a/drivers/gpu/ipu-v3/Kconfig
> +++ b/drivers/gpu/ipu-v3/Kconfig
> @@ -1,6 +1,6 @@
> config IMX_IPUV3_CORE
> tristate "IPUv3 core support"
> - depends on SOC_IMX5 || SOC_IMX6Q || ARCH_MULTIPLATFORM || COMPILE_TEST
> + depends on SOC_IMX5 || SOC_IMX6Q || ARCH_MULTIPLATFORM || COMPILE_TEST || ARCH_LAYERSCAPE
> depends on DRM || !DRM # if DRM=m, this can't be 'y'
> select BITREVERSE
> select GENERIC_ALLOCATOR if DRM
> --
> 2.17.1

Thank you for the patch, but this does not seem right.
ipuv3-crtc.c is part of DRM_IMX, which already depends on
IMX_IPUV3_CORE. How did you manage to make it try to compile imxdrm?

Since LS1028A does not have the IPUv3, keeping this under COMPILE_TEST
should be correct.

regards
Philipp

\
 
 \ /
  Last update: 2019-07-05 12:32    [W:0.059 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site