lkml.org 
[lkml]   [2019]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv6 27/28] PCI: mobiveil: Fix infinite-loop in the INTx process
    Date
    In the loop block, there is not code to update the loop key,
    this patch updates the loop key by re-read the INTx status
    register.

    Note: Need MV to test this fix.

    Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver")
    Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
    Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
    Reviewed-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
    Acked-by: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>
    Tested-by: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>
    ---
    V6:
    - Splited from #10 of v5 patches, no functional change.

    drivers/pci/controller/pcie-mobiveil.c | 12 +++++++++---
    1 files changed, 9 insertions(+), 3 deletions(-)

    diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
    index f35d14b..a5549cf 100644
    --- a/drivers/pci/controller/pcie-mobiveil.c
    +++ b/drivers/pci/controller/pcie-mobiveil.c
    @@ -359,8 +359,9 @@ static void mobiveil_pcie_isr(struct irq_desc *desc)

    /* Handle INTx */
    if (intr_status & PAB_INTP_INTX_MASK) {
    - shifted_status = csr_readl(pcie, PAB_INTP_AMBA_MISC_STAT) >>
    - PAB_INTX_START;
    + shifted_status = csr_readl(pcie, PAB_INTP_AMBA_MISC_STAT);
    + shifted_status &= PAB_INTP_INTX_MASK;
    + shifted_status >>= PAB_INTX_START;
    do {
    for_each_set_bit(bit, &shifted_status, PCI_NUM_INTX) {
    virq = irq_find_mapping(pcie->intx_domain,
    @@ -376,7 +377,12 @@ static void mobiveil_pcie_isr(struct irq_desc *desc)
    shifted_status << PAB_INTX_START,
    PAB_INTP_AMBA_MISC_STAT);
    }
    - } while ((shifted_status >> PAB_INTX_START) != 0);
    +
    + shifted_status = csr_readl(pcie,
    + PAB_INTP_AMBA_MISC_STAT);
    + shifted_status &= PAB_INTP_INTX_MASK;
    + shifted_status >>= PAB_INTX_START;
    + } while (shifted_status != 0);
    }

    /* read extra MSI status register */
    --
    1.7.1
    \
     
     \ /
      Last update: 2019-07-05 12:09    [W:4.207 / U:0.928 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site