lkml.org 
[lkml]   [2019]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [Patch v2 10/10] platform/x86/asus-wmi: using dev_get_drvdata directly
On Thu, Jul 4, 2019 at 5:37 AM Fuqian Huang <huangfq.daxian@gmail.com> wrote:
>
> Several drivers cast a struct device pointer to a struct
> platform_device pointer only to then call platform_get_drvdata().
> To improve readability, these constructs can be simplified
> by using dev_get_drvdata() directly.

v1 had been applied.

> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> Changes in v2:
> - Make the commit message more clearly.
>
> drivers/platform/x86/asus-wmi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 9b18a184e0aa..49049b02a015 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1353,8 +1353,7 @@ static umode_t asus_hwmon_sysfs_is_visible(struct kobject *kobj,
> struct attribute *attr, int idx)
> {
> struct device *dev = container_of(kobj, struct device, kobj);
> - struct platform_device *pdev = to_platform_device(dev->parent);
> - struct asus_wmi *asus = platform_get_drvdata(pdev);
> + struct asus_wmi *asus = dev_get_drvdata(dev->parent);
> int dev_id = -1;
> int fan_attr = -1;
> u32 value = ASUS_WMI_UNSUPPORTED_METHOD;
> --
> 2.11.0
>


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-07-04 15:26    [W:0.045 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site