Messages in this thread | | | Date | Thu, 4 Jul 2019 14:07:56 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code |
| |
On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote: > gcc-9 complains about a blatant uninitialized variable use that > all earlier compiler versions missed: > > drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] > > Return -EINVAL instead here. > > Cc: stable@vger.kernel.org > Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This is correct but missing that the above 'return ret' is broken, too. ret is initialized but 0 in that case.
And maybe we can use something else than -EINVAL for this case? I am on the go right now, I will look for a suggestion later.
[unhandled content-type:application/pgp-signature] | |