Messages in this thread | | | Date | Thu, 4 Jul 2019 11:17:01 +0100 | From | Stefan Hajnoczi <> | Subject | Re: [PATCH v2 1/3] vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock |
| |
On Wed, Jul 03, 2019 at 12:41:35PM +0200, Stefano Garzarella wrote: > On Wed, Jul 03, 2019 at 05:53:58PM +0800, Jason Wang wrote: > > On 2019/6/28 下午8:36, Stefano Garzarella wrote: > > Another more interesting question, I believe we will do singleton for > > virtio_vsock structure. Then what's the point of using vdev->priv to access > > the_virtio_vsock? It looks to me we can it brings extra troubles for doing > > synchronization. > > I thought about it when I tried to use RCU to stop the worker and I > think make sense. Maybe can be another series after this will be merged. > > @Stefan, what do you think about that?
Yes, let's make it a singleton and keep no other references to it.
Stefan [unhandled content-type:application/pgp-signature] | |