Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 4 Jul 2019 09:39:15 +0200 | Subject | Re: [PATCH 1/4] gpio: stp-xway: simplify error handling in xway_stp_probe() |
| |
On Wed, Jul 3, 2019 at 12:33 AM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Return early if devm_gpiochip_add_data() returns an error instead of > having two consecutive "if (!ret) ..." statements. > > Also make xway_stp_hw_init() return void because it unconditionally > returns 0. While here also update the kerneldoc comment for > xway_stp_hw_init(). > > These changes makes the error handling within the driver consistent. > No functional changes intended. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Patch applied.
Yours, Linus Walleij
| |