lkml.org 
[lkml]   [2019]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/4] gpio: stp-xway: simplify error handling in xway_stp_probe()
    On Wed, Jul 3, 2019 at 12:33 AM Martin Blumenstingl
    <martin.blumenstingl@googlemail.com> wrote:

    > Return early if devm_gpiochip_add_data() returns an error instead of
    > having two consecutive "if (!ret) ..." statements.
    >
    > Also make xway_stp_hw_init() return void because it unconditionally
    > returns 0. While here also update the kerneldoc comment for
    > xway_stp_hw_init().
    >
    > These changes makes the error handling within the driver consistent.
    > No functional changes intended.
    >
    > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

    Patch applied.

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2019-07-04 09:40    [W:6.958 / U:0.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site