Messages in this thread | | | Subject | Re: [PATCH] cifs: remove redundant assignment to variable rc | From | Colin Ian King <> | Date | Wed, 31 Jul 2019 16:54:31 +0100 |
| |
On 31/07/2019 16:34, Aurélien Aptel wrote: > "Dan Carpenter" <dan.carpenter@oracle.com> writes: >> You're just turning off GCC's static analysis (and introducing false >> positives) when you do that. We have seen bugs caused by this and never >> seen any bugs prevented by this style. > > You've never seen bugs prevented by initializing uninitialized > variables? Code can change overtime and I don't think coverity is > checked as often as it could be, meaning the var could end up being used > while uninitialized in the future.
gcc/clang should pick up uninitialized vars at compile time. also I run coverity daily on linux-next.
Colin
> > Anyway I won't die on this hill, merge this if you prefer. > > Cheers, >
| |