Messages in this thread | | | From | Masahiro Yamada <> | Date | Wed, 31 Jul 2019 18:23:01 +0900 | Subject | Re: [PATCH] linux/coff.h: add include guard |
| |
Hi Andrew,
On Wed, Jul 31, 2019 at 4:52 AM Andrew Morton <akpm@linux-foundation.org> wrote: > > On Mon, 29 Jul 2019 00:47:28 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > > Add a header include guard just in case. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > Looks like this file is unused at least in the kernel tree, > > but I am not it is OK to delete it. > > arch/alpha/boot/tools/objstrip.c includes it but I don't think it's > actually needed. Yes, it would be nice to kill coff.h.
After some consideration, I think it is better to keep it until we dump the alpha support entirely.
The following line in arch/alpha/boot/tools/objstrip.c references a macro in <linux/coff.h>:
if (!(aout->fh.f_flags & COFF_F_EXEC)) {
I was not able to build objstrip.c anyway, but I think it is better to keep the can of worms closed for now.
Could you apply this as-is please?
My motivation is to allow Kbuild to detect missing include guard:
https://patchwork.kernel.org/patch/11063011/
Before I enable this checker, I want to fix as many headers as possible.
-- Best Regards Masahiro Yamada
| |