Messages in this thread | | | Date | Wed, 31 Jul 2019 18:09:27 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH] arm64: vdso: Fix Makefile regression |
| |
On Mon, Jul 29, 2019 at 01:54:21PM +0100, Vincenzo Frascino wrote: > Using an old .config in combination with "make oldconfig" can cause > an incorrect detection of the compat compiler: > > $ grep CROSS_COMPILE_COMPAT .config > CONFIG_CROSS_COMPILE_COMPAT_VDSO="" > > $ make oldconfig && make > arch/arm64/Makefile:58: gcc not found, check CROSS_COMPILE_COMPAT. > Stop. > > Accordingly to the section 7.2 of the GNU Make manual "Syntax of > Conditionals", "When the value results from complex expansions of > variables and functions, expansions you would consider empty may > actually contain whitespace characters and thus are not seen as > empty. However, you can use the strip function to avoid interpreting > whitespace as a non-empty value." > > Fix the issue adding strip to the CROSS_COMPILE_COMPAT string > evaluation. > > Cc: Will Deacon <will@kernel.org> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Reported-by: Matteo Croce <mcroce@redhat.com> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Queued for 5.3-rc3. Thanks.
-- Catalin
| |