lkml.org 
[lkml]   [2019]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] watchdog:alim1535_wdt: Fix data race in ali_settimer() concerning ali_timeout_bits variable.
    Hi Mark,

    On Wed, Jul 31, 2019 at 09:17:13AM -0700, Mark Balantzyan wrote:
    > Hi Guenter,
    >
    > If it's not too much too ask, I also propose to rewrite alim1535_wdt to use
    > the watchdog subsystem as I believe we are making progress toward the
    > similar end in pc87413_wdt, as my evaluation ends in some weeks.
    >

    Please, no. We still have ways to go with that one driver, and we'll be
    stuck with a patch which I can't accept because of lack of testing.
    I (and you) really need to talk to your evaluators why they ask you
    to make those changes. This is highly inappropriate. The Linux kernel
    is not an feasible target for such an evaluation. This is setting
    you up for failure, and it is a waste of both your and my time.

    Are you really working for or on belalf of the Linux Foundation ?
    They should know better. And if Google is involved, I am embarassed
    for my employer. If they really want people to do work like this,
    they should also provide reviewers and coaching staff. They should
    most definitely not expect kernel maintainers to do it for them.

    Thanks,
    Guenter

    \
     
     \ /
      Last update: 2019-07-31 18:44    [W:2.199 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site