Messages in this thread | | | Subject | Re: [PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire | From | Paolo Bonzini <> | Date | Wed, 31 Jul 2019 18:39:59 +0200 |
| |
On 31/07/19 15:14, Vitaly Kuznetsov wrote: > Paolo Bonzini <pbonzini@redhat.com> writes: > >> On 31/07/19 13:27, Wanpeng Li wrote: >>> From: Wanpeng Li <wanpengli@tencent.com> >>> >>> kvm_set_pending_timer() will take care to wake up the sleeping vCPU which >>> has pending timer, don't need to check this in apic_timer_expired() again. >> >> No, it doesn't. kvm_make_request never kicks the vCPU. >> > > Hm, but kvm_set_pending_timer() currently looks like: > > void kvm_set_pending_timer(struct kvm_vcpu *vcpu) > { > kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu); > kvm_vcpu_kick(vcpu); > }
Doing "git fetch" could have helped indeed.
Paolo
| |