lkml.org 
[lkml]   [2019]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [GIT PULL] Wimplicit-fallthrough patches for 5.3-rc2
Date
Kalle Valo <kvalo@codeaurora.org> writes:

> "Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
>
>> On 7/27/19 1:08 PM, Linus Torvalds wrote:
>>
>>>
>>> Ok, I have tried re-pulling and if it passes my build tests cleanly
>>> I'll push the result out.
>>>
>>
>> Awesome. :)
>
> BTW, now when using ccache 3.2.4 (which I admit is an old release from
> 2015 but included still in Ubuntu 16.04) I see a lot of fall-through
> warnings when building the kernel. I reported this to Gustavo before but
> didn't find the time to answer back to his extra questions, sorry about
> that.
>
> I did investigate the issue at the time and IIRC it was because ccache
> strips away the comments (including the fallback comments) before
> feeding the source file to the compiler. Apparently newer ccache
> versions has a setting to avoid that but I have not tried upgrading yet.
> But anyone using old ccache should definitely upgrade.

I just installed ccache 3.4.1-1 from Ubuntu 18.04 and that seemed to fix
the problem, the big number of fallthrough warnings are now gone. No
extra configuration needed.

--
Kalle Valo

\
 
 \ /
  Last update: 2019-07-30 16:45    [W:0.532 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site